<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104983/">http://git.reviewboard.kde.org/r/104983/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Andrea Iacovitti.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch enable rendering of css border for styled select elements (combobox+listview).
This is done by using KdeUiProxyStyle as already done by other widgets in khtml.
For styled combobox the drop down arrow is rendered by drawing PE_IndicatorArrowDown of the base style,
so it will look different depending on the system style being in use.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">. khtml testregression -> no further test fails
. tested against different basestyle: oxygen, qtcurve, available qt styles (plastique, qcleanlooks ...)
. tested against Qt 4.7.4, Qt 4.8.1
. daily browsing</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=299934">299934</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=300227">300227</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/css/html4.css <span style="color: grey">(9f4d17b)</span></li>
<li>khtml/rendering/render_form.h <span style="color: grey">(2be4df5)</span></li>
<li>khtml/rendering/render_form.cpp <span style="color: grey">(b4cf136)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104983/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104983/s/573/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/18/B9iyD_400x100.png" style="border: 1px black solid;" alt="shoot of a bko page before/after the patch" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>