Review Request: KJS: improve regex flag scanning

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104974/#review13944
-----------------------------------------------------------


This review has been submitted with commit e2f5d87a29f4a06b3056bc6e89f61b2a0df9124e by Rolf Eike Beer to branch KDE/4.8.

- Commit Hook


On May 17, 2012, 5:17 p.m., Rolf Eike Beer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104974/
> -----------------------------------------------------------
> 
> (Updated May 17, 2012, 5:17 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Only scan the list of flags once, and only if there is a list at all.
> 
> It also fixes the S15.10.4.1_A5_T1 and S15.10.4.1_A5_T1 tests of ECMA test262:
> a regex flag may be given only once.
> 
> I also checked Firefox behaviour, it also throws a syntax error in this case.
> 
> 
> Diffs
> -----
> 
>   kjs/regexp_object.cpp a6b6974 
> 
> Diff: http://git.reviewboard.kde.org/r/104974/diff/
> 
> 
> Testing
> -------
> 
> Run ECMA testsuite. These 2 tests now pass, no other changes.
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120517/67b936dd/attachment.htm>