Review Request: KJS: improve regex flag scanning

Rolf Eike Beer kde at
Thu May 17 18:17:07 BST 2012

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


Only scan the list of flags once, and only if there is a list at all.

It also fixes the S15.10.4.1_A5_T1 and S15.10.4.1_A5_T1 tests of ECMA test262:
a regex flag may be given only once.

I also checked Firefox behaviour, it also throws a syntax error in this case.


  kjs/regexp_object.cpp a6b6974 



Run ECMA testsuite. These 2 tests now pass, no other changes.


Rolf Eike Beer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list