Review Request: KJS: improve regex flag scanning
Rolf Eike Beer
kde at opensource.sf-tec.de
Thu May 17 18:17:07 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104974/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
Only scan the list of flags once, and only if there is a list at all.
It also fixes the S15.10.4.1_A5_T1 and S15.10.4.1_A5_T1 tests of ECMA test262:
a regex flag may be given only once.
I also checked Firefox behaviour, it also throws a syntax error in this case.
Diffs
-----
kjs/regexp_object.cpp a6b6974
Diff: http://git.reviewboard.kde.org/r/104974/diff/
Testing
-------
Run ECMA testsuite. These 2 tests now pass, no other changes.
Thanks,
Rolf Eike Beer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120517/22c7fc75/attachment.htm>
More information about the kde-core-devel
mailing list