Review Request: Require Qt 4.8 in kdelibs KDE/4.8 branch

[Andre Heinecke]

> On April 13, 2012, 9:51 p.m., Dawit Alemayehu wrote:
> > The commit that has caused the compilation problem has already been addressed:
> > 
> > http://commits.kde.org/kdelibs/cd71839b04d7c754b9ec18f7b56522958b504006
> > http://commits.kde.org/kdelibs/d82f313500f9e4fe3a7e5ddef43650c31b59c8e3
> >
> 
> Martin Gräßlin wrote:
>     thanks for the info - no idea why I did not find that one yesterday...

Happened again with https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=2cf247f4ebdee44d0620e57f9cd17fa963b36b73
The QNetworkReply::setFinished ( http://qt-project.org/doc/qt-4.8/qnetworkreply.html#setFinished ) was introduced in Qt 4.8


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104593/#review12410
-----------------------------------------------------------


On April 13, 2012, 8:07 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104593/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 8:07 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Since https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=86dcd810bc7bb1effb7a2831d0e7d49cab6e120d kdelibs KDE/4.8 requires Qt 4.8. Without it we get the following build error:
> kdecore/network/ktcpsocket.cpp:47:10: error: ‘TlsV1SslV3’ is not a member of ‘QSsl’
> kdecore/network/ktcpsocket.cpp:49:10: error: ‘SecureProtocols’ is not a member of ‘QSsl’
> 
> Given thread http://lists.kde.org/?l=kde-core-devel&m=133405344728456&w=2 I think it is best to require Qt 4.8 in CMake to get proper warnings at cmake check and not get a useless build error.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 040a24f 
> 
> Diff: http://git.reviewboard.kde.org/r/104593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120516/c3f88cc4/attachment.htm>