Review Request: kjs: Fix Errorprototype inheritance

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104908/#review13781
-----------------------------------------------------------

Ship it!


Ship It!

- Maks Orlovich


On May 10, 2012, 7:01 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104908/
> -----------------------------------------------------------
> 
> (Updated May 10, 2012, 7:01 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Fix Errorprototype inheritance, it must inherit from ErrorInstance to get the correct classInfo
> 
> 
> Without the patch
> 
> Error.prototype.toString=Object.prototype.toString;
> print(Error.prototype.toString());
> 
> will tell us that Error is an Object, not an Error
> 
> before:
> [object Object]
> 
> after:
> [object Error]
> 
> 
> Diffs
> -----
> 
>   kjs/error_object.h c3cd64d 
>   kjs/error_object.cpp 1f176d7 
> 
> Diff: http://git.reviewboard.kde.org/r/104908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120513/a064646d/attachment.htm>