Review Request: kjs: Fix Errorprototype inheritance

Bernd Buschinski b.buschinski at googlemail.com
Thu May 10 20:01:38 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104908/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

kjs: Fix Errorprototype inheritance, it must inherit from ErrorInstance to get the correct classInfo


Without the patch

Error.prototype.toString=Object.prototype.toString;
print(Error.prototype.toString());

will tell us that Error is an Object, not an Error

before:
[object Object]

after:
[object Error]


Diffs
-----

  kjs/error_object.h c3cd64d 
  kjs/error_object.cpp 1f176d7 

Diff: http://git.reviewboard.kde.org/r/104908/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120510/6e9308fd/attachment.htm>


More information about the kde-core-devel mailing list