Review Request: dataprotocol: simplify helper code

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104860/
-----------------------------------------------------------

(Updated May 6, 2012, 6:10 p.m.)


Review request for kdelibs.


Changes
-------

Rebased diff against current KDE/4.8 branch.


Description
-------

-add some "const" and "static"
-remove function parameters that always have the same values, use local statics
 in the function to hold these
-QChar(QLatin1Char('\0')) => QChar()
-QChar == QLatin1Char('\0') => QChar::isNull()


Diffs (updated)
-----

  kio/kio/dataprotocol.cpp e614476 

Diff: http://git.reviewboard.kde.org/r/104860/diff/


Testing
-------

-build whole kdelibs
-dataprotocol testcases still pass


Thanks,

Rolf Eike Beer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120506/d2f7bd33/attachment.htm>