Review Request: dataprotocol: simplify helper code

Rolf Eike Beer kde at opensource.sf-tec.de
Fri May 4 19:24:04 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104860/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

-add some "const" and "static"
-remove function parameters that always have the same values, use local statics
 in the function to hold these
-QChar(QLatin1Char('\0')) => QChar()
-QChar == QLatin1Char('\0') => QChar::isNull()


Diffs
-----

  kio/kio/dataprotocol.cpp 9fdd702 

Diff: http://git.reviewboard.kde.org/r/104860/diff/


Testing
-------

-build whole kdelibs
-dataprotocol testcases still pass


Thanks,

Rolf Eike Beer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120504/25d14205/attachment.htm>


More information about the kde-core-devel mailing list