What about DATAKIOSLAVE?

[Rolf Eike Beer]

Am Samstag, 5. Mai 2012, 12:16:58 schrieb Leo Savernik:
> Am Freitag, 4. Mai 2012 18:53 schrieb Rolf Eike Beer:
> > In kio/kio/dataprotocol.h you will find this documentation of that
> > #define:
> > 
> > // DATAKIOSLAVE: define if you want to compile this into a stand-alone
> > //              kioslave
> > 
> > And in this header and the implementation a bunch of #ifdef's depending on
> > it. But I can't see it being set or used anywhere. Would anyone object on
> > just killing it altogether?
> 
> That's simple, you can compile it into a standalone executable that is
> registered like any other kioslave.

Yes, that what I guessed.

> However, given that data-urls don't depend on any external data it seemed
> overkill, therefore I added a special hack that the kio-dataslave is invoked
> in-process on the client side.
> 
> Hence, by defining DATAKIOSLAVE you can disable this special hack and
> compile dataprotocol.* into a standalone kioslave.

So what we currently have is the hack, with this define one would get the 
"normal" behaviour.

> Which bug or breakage do you fix by removing DATAKIOSLAVE?

I was just wondering what that stuff is all about since it seems unused. Maybe 
you could just write this down in a comment?

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120505/6a4a0db2/attachment.sig>