Review Request: Minor krazy2 warning fixes

Tue May 1 10:55:06 BST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104785/#review13196
-----------------------------------------------------------

kio/bookmarks/kbookmarkdombuilder.cc
<http://git.reviewboard.kde.org/r/104785/#comment10287>

    That's a trivial issue, but why unpad the parenthesis here and not in the previous connect statement?

    This unpadding has nothing to do with SIGNAL/SLOT normalization and/or krazy fixes. I think the kdelibs coding style suggests unpadding parentheses but if you do it, keep it consistent.

kio/bookmarks/kbookmarkmanager.cc
<http://git.reviewboard.kde.org/r/104785/#comment10288>

    If you gonna unpad parentheses, this needs fixing: "QObject::connect( d->m_kDirWatch" -> "QObject::connect(d->m_kDirWatch"

kio/bookmarks/kbookmarkmanager.cc
<http://git.reviewboard.kde.org/r/104785/#comment10289>

    Here too.

kio/bookmarks/kbookmarkmanager.cc
<http://git.reviewboard.kde.org/r/104785/#comment10290>

    Here too.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10291>

    Here too.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10292>

    Here too.

    Plus, why not introduce a "this" pointer here as well (I mean the connect overload with a destination pointer)? You have changed it everywhere else, it's just inconsistent if you omit it here.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10293>

    Inconsistent unpadding here too. You unpad the addAction function (at the end) but not i18n.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10294>

    Here too.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10295>

    Here too.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10296>

    Here too.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10298>

    You haven't normalized here.

kio/bookmarks/kbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10297>

    You haven't normalized here. You just used a different connect overload.

kio/bookmarks/konqbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10299>

    Incosistent unpadding.

kio/bookmarks/konqbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10300>

    Same here.

kio/bookmarks/konqbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10301>

    Same here.

kio/bookmarks/konqbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10302>

    Same here.

kio/kfile/kfilemetadataprovider.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10303>

    This doesn't need normalization. And since kdelibs coding style suggests padding operators, the whitespace should remain.

kio/kfile/kfilemetadataprovider.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10304>

    Same here.

kioslave/http/kcookiejar/kcookiejar_include.h
<http://git.reviewboard.kde.org/r/104785/#comment10305>

    Does it compile without the include?

nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10306>

    Incosistent unpadding.

nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10307>

    Here too.

nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10308>

    Here too.

nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10309>

    Here too.

nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10310>

    Here too.

nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10311>

    Here too.

nepomuk/query/dateparser.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10312>

    You introduced a space after 'if'.

nepomuk/query/dateparser.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10313>

    You introduced a space after 'if'.

nepomuk/query/dateparser.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10314>

    Incosistent unpadding.

nepomuk/query/dateparser.cpp
<http://git.reviewboard.kde.org/r/104785/#comment10315>

    Space after 'if'.

I have made a few comments, mostly about code inconsistencies. Since it's a matter of taste of the maintainer I didn't open issues, except when needed.

- Konstantinos Smanis

On April 30, 2012, 11:50 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104785/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 11:50 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The following patch fixes the following krazy2 warnings:
> 
>  - Use const references in Q_FOREACH statements where appropriate.
>  - Normalize yet more signal/slot connections (missing from the first go round).
>  - Use brackets instead of double-quotes for the 'config*' header files.
>  - Fix the #ifdef statements in header files to reflect the header filename.
> 
> I did this a long time ago, but never pushed upstream. As part of my spring clean up I want to push this local changes upstream. Any objections ?
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmarkdialog.cc 713ceff 
>   kio/bookmarks/kbookmarkdombuilder.cc 8e0be3c 
>   kio/bookmarks/kbookmarkimporter.cc 08210f7 
>   kio/bookmarks/kbookmarkmanager.cc d8a9cb7 
>   kio/bookmarks/kbookmarkmenu.cc deb973b 
>   kio/bookmarks/konqbookmarkmenu.cc 4fc6be0 
>   kio/kfile/kfilemetadataprovider.cpp 8caa0c2 
>   kio/kfile/kfilemetadataprovider_p.h 09d924a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 5103087 
>   kio/kfile/kimagefilepreview.cpp 74ef8b7 
>   kio/kio/accessmanager.cpp e535c8a 
>   kio/kio/chmodjob.cpp 85e0c2c 
>   kio/kio/job.h aeaffa2 
>   kio/kio/job.cpp 5e18998 
>   kio/kio/jobuidelegate.cpp 85679c2 
>   kio/kio/kdesktopfileactions.cpp edf2e9c 
>   kio/kio/kfileitemactions.h 27ab4e3 
>   kio/kio/kfileitemactions.cpp c79a434 
>   kio/kio/kfilemetainfoitem.cpp 1cab458 
>   kio/kio/ksambasharedata.cpp aebcb04 
>   kio/kio/kurifilter.h 289b910 
>   kio/kio/kurifilter.cpp 0144a2c 
>   kio/kio/renamedialog.cpp 11e55a9 
>   kio/misc/kpac/proxyscout.cpp 0068ce7 
>   kio/misc/kpac/script.cpp a595301 
>   kioslave/http/kcookiejar/kcookiejar_include.h 4053a53 
>   kioslave/http/tests/httpauthenticationtest.h 35b822a 
>   nepomuk/core/resourcedata.cpp 0a5295b 
>   nepomuk/query/dateparser.cpp 9bd2e1a 
>   nepomuk/rcgen/ontologyparser.cpp f9f8673 
>   nepomuk/rcgen/property.cpp 51d9c07 
>   nepomuk/types/class.cpp 0210537 
>   nepomuk/types/ontology.cpp 124e88c 
>   nepomuk/types/ontologymanager.cpp 10d1031 
>   nepomuk/types/property.cpp 06daf3c 
>   nepomuk/utils/datefacet.cpp 386aa00 
> 
> Diff: http://git.reviewboard.kde.org/r/104785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120501/2d6f92c9/attachment.htm>