Review Request: Minor krazy2 warning fixes

Dawit Alemayehu adawit at
Tue May 1 00:50:59 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated April 30, 2012, 11:50 p.m.)

Review request for kdelibs.


Added few more fixes.


The following patch fixes the following krazy2 warnings:

 - Use const references in Q_FOREACH statements where appropriate.
 - Normalize yet more signal/slot connections (missing from the first go round).
 - Use brackets instead of double-quotes for the 'config*' header files.
 - Fix the #ifdef statements in header files to reflect the header filename.

I did this a long time ago, but never pushed upstream. As part of my spring clean up I want to push this local changes upstream. Any objections ?

Diffs (updated)

  kio/bookmarks/ 713ceff 
  kio/bookmarks/ 8e0be3c 
  kio/bookmarks/ 08210f7 
  kio/bookmarks/ d8a9cb7 
  kio/bookmarks/ deb973b 
  kio/bookmarks/ 4fc6be0 
  kio/kfile/kfilemetadataprovider.cpp 8caa0c2 
  kio/kfile/kfilemetadataprovider_p.h 09d924a 
  kio/kfile/kfilemetadatareaderprocess.cpp 5103087 
  kio/kfile/kimagefilepreview.cpp 74ef8b7 
  kio/kio/accessmanager.cpp e535c8a 
  kio/kio/chmodjob.cpp 85e0c2c 
  kio/kio/job.h aeaffa2 
  kio/kio/job.cpp 5e18998 
  kio/kio/jobuidelegate.cpp 85679c2 
  kio/kio/kdesktopfileactions.cpp edf2e9c 
  kio/kio/kfileitemactions.h 27ab4e3 
  kio/kio/kfileitemactions.cpp c79a434 
  kio/kio/kfilemetainfoitem.cpp 1cab458 
  kio/kio/ksambasharedata.cpp aebcb04 
  kio/kio/kurifilter.h 289b910 
  kio/kio/kurifilter.cpp 0144a2c 
  kio/kio/renamedialog.cpp 11e55a9 
  kio/misc/kpac/proxyscout.cpp 0068ce7 
  kio/misc/kpac/script.cpp a595301 
  kioslave/http/kcookiejar/kcookiejar_include.h 4053a53 
  kioslave/http/tests/httpauthenticationtest.h 35b822a 
  nepomuk/core/resourcedata.cpp 0a5295b 
  nepomuk/query/dateparser.cpp 9bd2e1a 
  nepomuk/rcgen/ontologyparser.cpp f9f8673 
  nepomuk/rcgen/property.cpp 51d9c07 
  nepomuk/types/class.cpp 0210537 
  nepomuk/types/ontology.cpp 124e88c 
  nepomuk/types/ontologymanager.cpp 10d1031 
  nepomuk/types/property.cpp 06daf3c 
  nepomuk/utils/datefacet.cpp 386aa00 




Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list