Review Request: KJS: Correctly get begin, deleteCount for Splice

Bernd Buschinski b.buschinski at
Wed Mar 21 23:55:17 GMT 2012

This is an automatically generated e-mail. To reply, visit:

(Updated March 21, 2012, 11:55 p.m.)

Review request for kdelibs.


- replaced unsigned int with uint32_t
- replaced C-sytle cast with static_cast
- Fixed Step step 7, now uses toInteger() according to the specs


Corretly get the begin and deleteCount for Splice. The current implementation only allows max int values.
But ecmascript allows max UInt32 (via ToInteger(which is a double) and limits it to the array length(uint32))

This addresses bug 276629.

Diffs (updated)

  kjs/array_object.cpp 0da29b0 



Confirmed via ecmascript


Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list