Review Request: KJS: Correctly get begin, deleteCount for Splice

[Bernd Buschinski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104104/
-----------------------------------------------------------

(Updated March 21, 2012, 11:55 p.m.)


Review request for kdelibs.


Changes
-------

- replaced unsigned int with uint32_t
- replaced C-sytle cast with static_cast
- Fixed Step 5.4.4.12 step 7, now uses toInteger() according to the specs


Description
-------

Corretly get the begin and deleteCount for Splice. The current implementation only allows max int values.
But ecmascript 15.4.4.12 allows max UInt32 (via ToInteger(which is a double) and limits it to the array length(uint32))


This addresses bug 276629.
    http://bugs.kde.org/show_bug.cgi?id=276629


Diffs (updated)
-----

  kjs/array_object.cpp 0da29b0 

Diff: http://git.reviewboard.kde.org/r/104104/diff/


Testing
-------

Confirmed via ecmascript 15.4.4.12


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120321/d45e5a97/attachment.htm>