Review Request: KJS: Correctly get begin, deleteCount for Splice

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104104/#review11666
-----------------------------------------------------------



kjs/array_object.cpp
<http://git.reviewboard.kde.org/r/104104/#comment9266>

    Consider using uint32_t?
    



kjs/array_object.cpp
<http://git.reviewboard.kde.org/r/104104/#comment9267>

    Don't ever use C-style casts in C++; use static_cast here instead



kjs/array_object.cpp
<http://git.reviewboard.kde.org/r/104104/#comment9268>

    args[1]->toInteger() here, per 15.4.4.12 step 7


- Maks Orlovich


On Feb. 28, 2012, 3:12 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104104/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2012, 3:12 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Corretly get the begin and deleteCount for Splice. The current implementation only allows max int values.
> But ecmascript 15.4.4.12 allows max UInt32 (via ToInteger(which is a double) and limits it to the array length(uint32))
> 
> 
> This addresses bug 276629.
>     http://bugs.kde.org/show_bug.cgi?id=276629
> 
> 
> Diffs
> -----
> 
>   kjs/array_object.cpp 0da29b0 
> 
> Diff: http://git.reviewboard.kde.org/r/104104/diff/
> 
> 
> Testing
> -------
> 
> Confirmed via ecmascript 15.4.4.12
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120320/8baf32ac/attachment.htm>