Review Request: KJS: No longer treat invalid hex as string

[Bernd Buschinski]

> On March 20, 2012, 9:18 p.m., Maks Orlovich wrote:
> > kjs/lexer.cpp, line 320
> > <http://git.reviewboard.kde.org/r/104076/diff/1/?file=51115#file51115line320>
> >
> >     Any reason you're still permitting this recovery (testcase: "\x")?
> >     
> >

Because I feared it would break even more, or rather there was some string appending magic that would make it valid.
In but there should be no way, \x must be followed by 2 valid hex values. I will update the patch


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104076/#review11663
-----------------------------------------------------------


On Feb. 25, 2012, 4:31 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104076/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2012, 4:31 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KJS: No longer treat invalid hex as string
> 
> Fixes ecmascript
> - S7.8.4_A6.1_T4 (invalid hex \x0G)
> - S7.8.4_A6.2_T1 & S7.8.4_A6.2_T2 (too short hex \xA)
> 
> 
> Diffs
> -----
> 
>   kjs/lexer.cpp e89de5f 
> 
> Diff: http://git.reviewboard.kde.org/r/104076/diff/
> 
> 
> Testing
> -------
> 
> tested with ecmascript, no new regressions
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120321/e2d125c3/attachment.htm>