Review Request: KJS: No longer treat invalid hex as string

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104076/#review11663
-----------------------------------------------------------


This is consistent with the spec; but I am worried that in the wild behavior may not match the spec yet (at least it doesn't for Chrome 18; it may be safe since FF seems to follow this, but I don't have a good version at spec now)



kjs/lexer.cpp
<http://git.reviewboard.kde.org/r/104076/#comment9261>

    Any reason you're still permitting this recovery (testcase: "\x")?
    
    


- Maks Orlovich


On Feb. 25, 2012, 4:31 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104076/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2012, 4:31 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KJS: No longer treat invalid hex as string
> 
> Fixes ecmascript
> - S7.8.4_A6.1_T4 (invalid hex \x0G)
> - S7.8.4_A6.2_T1 & S7.8.4_A6.2_T2 (too short hex \xA)
> 
> 
> Diffs
> -----
> 
>   kjs/lexer.cpp e89de5f 
> 
> Diff: http://git.reviewboard.kde.org/r/104076/diff/
> 
> 
> Testing
> -------
> 
> tested with ecmascript, no new regressions
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120320/f4f32e4c/attachment.htm>