Review Request: Added fallback for real username in kcm module to use KUser::FullName

Raphael Kubo da Costa rakuco at freebsd.org
Wed Jun 27 19:03:03 BST 2012



> On June 27, 2012, 4:50 p.m., Raphael Kubo da Costa wrote:
> > Makes sense, please commit to master.
> 
> Aleksey Yermakov wrote:
>     I'm afraid, I don't have write rights. Could you please point me to some documentation which will help me commit this patch?
>

I will commit this one for you then. The basic documentation is this one: http://techbase.kde.org/Contribute/Get_a_Contributor_Account. In short, if you send a few more patches and show that you're interested in keeping contributing, people will encourage you to apply for an account and second the nomination (it may sound pompous but it's really simple :-)


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104965/#review15206
-----------------------------------------------------------


On June 27, 2012, 4:29 p.m., Aleksey Yermakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104965/
> -----------------------------------------------------------
> 
> (Updated June 27, 2012, 4:29 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Added fallback for real username in kcm module.
> 
> Really helps in issues like this: http://bugs.rosalinux.ru/show_bug.cgi?id=179
> 
> Besides, such method seems natural, considering that change of real username in kcm module calls chfn to change real name in finger db, which will be reflected back in KUser::FullName.
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/main.cpp 2471444 
> 
> Diff: http://git.reviewboard.kde.org/r/104965/diff/
> 
> 
> Testing
> -------
> 
> Tested by QA crew of ROSA Desktop for ROSA Desktop 2012 LTS.
> 
> 
> Thanks,
> 
> Aleksey Yermakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120627/5d121c47/attachment.htm>


More information about the kde-core-devel mailing list