Review Request: Added fallback for real username in kcm module to use KUser::FullName
Aleksey Yermakov
alexey.yermakov at rosalab.ru
Wed Jun 27 18:03:20 BST 2012
> On June 27, 2012, 4:50 p.m., Raphael Kubo da Costa wrote:
> > Makes sense, please commit to master.
I'm afraid, I don't have write rights. Could you please point me to some documentation which will help me commit this patch?
- Aleksey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104965/#review15206
-----------------------------------------------------------
On June 27, 2012, 4:29 p.m., Aleksey Yermakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104965/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 4:29 p.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> Added fallback for real username in kcm module.
>
> Really helps in issues like this: http://bugs.rosalinux.ru/show_bug.cgi?id=179
>
> Besides, such method seems natural, considering that change of real username in kcm module calls chfn to change real name in finger db, which will be reflected back in KUser::FullName.
>
>
> Diffs
> -----
>
> kdepasswd/kcm/main.cpp 2471444
>
> Diff: http://git.reviewboard.kde.org/r/104965/diff/
>
>
> Testing
> -------
>
> Tested by QA crew of ROSA Desktop for ROSA Desktop 2012 LTS.
>
>
> Thanks,
>
> Aleksey Yermakov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120627/d8870536/attachment.htm>
More information about the kde-core-devel
mailing list