Question regarding compatibility for kdecore and KDE4_ENABLE_FINAL

[Michael Pyne]

On Thursday, June 14, 2012 15:36:47 David Faure wrote:
> On Tuesday 12 June 2012 20:42:28 Michael Pyne wrote:
> > Hi all,
> > 
> > Bug 301419 has been reported against kdelibs due to a build failure when
> > KDE4_ENABLE_FINAL is used, introduced by some commits of mine to perform
> > even more sanity checking in the KSharedDataCache.
> > 
> > These commits use exceptions (as are already used in khtml) since they are
> > actually "the right tool" in the context of where they are used, and
> > because refactoring everything to use error codes everywhere (ECE) would
> > have risked introducing more bugs.
> > 
> > In order to minimize the changes to kdecore I only added the CMake magic
> > to
> > enable exceptions for only kshareddatacache.cpp. This doesn't work when
> > KDE4_ENABLE_FINAL is used, as the project-wide CXXFLAGS are used in that
> > case.
> > 
> > The Mageia devs have a proposed patch [1] to enable exceptions for all of
> > kdecore, which fixes the issue. Is it acceptable for me to go this route?
> > The only real alternative this late in the game is to back out the sanity
> > checks to the 4.8.3 status or to explicitly say that KDE4_ENABLE_FINAL
> > will
> > not work for this tarball although it worked for 4.8.3, both of which I
> > consider less desirable. But I don't want to make the change if there are
> > good reasons to avoid it.
> 
> The alternative would be to enable exceptions for all of kdecore only if
> enable-final is enabled.

Sorry to be unclear -- that's exactly what the Mageia patch accomplishes. They 
only flip the exceptions bit for enable-final builds. If that sounds agreeable 
I intend on making that alteration and forwarding the patch to kde-packager.

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120614/14049712/attachment.sig>