Review Request: kjs: Implement Object.create

Bernd Buschinski b.buschinski at googlemail.com
Fri Jun 1 15:56:54 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104630/
-----------------------------------------------------------

(Updated June 1, 2012, 2:56 p.m.)


Review request for kdelibs.


Changes
-------

I gravely misinterpreted

"If Type(O) is not Object or Null throw a TypeError exception."
as
if (!O->isObject || O->isNull()) throw
but it was meant as
if (!(O->isObject || O->isNull())) throw

as we now have, but we can't get an Object out of Null, so we have to set it differently


Description
-------

This needs https://git.reviewboard.kde.org/r/104629/ Object.defineProperties

Strictly implemented to ecma 15.2.3.5 Object.create


Diffs (updated)
-----

  kjs/object_object.cpp 986f03f 

Diff: http://git.reviewboard.kde.org/r/104630/diff/


Testing
-------

ecmascript & daily surfing


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120601/41e943c8/attachment.htm>


More information about the kde-core-devel mailing list