Review Request: kjs: Implement JSON.stringify

Bernd Buschinski b.buschinski at googlemail.com
Fri Jun 1 14:30:32 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/
-----------------------------------------------------------

(Updated June 1, 2012, 1:30 p.m.)


Review request for kdelibs.


Changes
-------

- properly remember holder
- fixes crash for js code like

var b = 42;
function white(a,b,c) { return 10; }
var o = JSON.stringify(b, white);


Description
-------

kjs: Implement JSON.stringify

patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse)


Diffs (updated)
-----

  kjs/CMakeLists.txt 1188064 
  kjs/CommonIdentifiers.h 8ee40e8 
  kjs/json_object.h PRE-CREATION 
  kjs/json_object.cpp PRE-CREATION 
  kjs/jsonstringify.h PRE-CREATION 
  kjs/jsonstringify.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105057/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120601/872551e0/attachment.htm>


More information about the kde-core-devel mailing list