Review Request: Fix for clipped security icon in Konqueror when favicon is now shown

Dawit Alemayehu adawit at
Tue Jul 31 16:52:07 BST 2012

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Base Apps.


This patch is partially a code clean up and partially a fix. It addresses the issue of the security icon being clipped on secure sites where the favorite icon is missing from the address bar as shown in the first screenshot below. For some reason, instead of simply making space for the secuirty icon, the current code unnecessarily attempts to take the size of the favorite icon into consideration. The second and third screenshots of the address bar, taken after the patch was applied, show that doing so was unnecessary.


  konqueror/src/konqcombo.cpp cdf840a 




address bar without fix
address bar with fix
address bar with fix & favicon


Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list