<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105805/">http://git.reviewboard.kde.org/r/105805/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is partially a code clean up and partially a fix. It addresses the issue of the security icon being clipped on secure sites where the favorite icon is missing from the address bar as shown in the first screenshot below. For some reason, instead of simply making space for the secuirty icon, the current code unnecessarily attempts to take the size of the favorite icon into consideration. The second and third screenshots of the address bar, taken after the patch was applied, show that doing so was unnecessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqcombo.cpp <span style="color: grey">(cdf840a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105805/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105805/s/657/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/31/konq_address_bar_400x100.png" style="border: 1px black solid;" alt="address bar without fix" /></a>
<a href="http://git.reviewboard.kde.org/r/105805/s/658/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/31/konq_address_bar_after_fix_400x100.png" style="border: 1px black solid;" alt="address bar with fix" /></a>
<a href="http://git.reviewboard.kde.org/r/105805/s/659/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/31/konq_address_bar_after_fix_with_favicon_400x100.png" style="border: 1px black solid;" alt="address bar with fix & favicon" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>