Review Request: kjs: Implement Date.toJSON

Bernd Buschinski b.buschinski at googlemail.com
Fri Jul 20 23:42:53 BST 2012



> On July 20, 2012, 10:22 p.m., Rolf Eike Beer wrote:
> > kjs/CommonIdentifiers.h, line 59
> > <http://git.reviewboard.kde.org/r/105631/diff/1/?file=73994#file73994line59>
> >
> >     toJSON is already present and you add toISOString? Are you sure this is the right diff?

yep, general toJSON is already present, also Date.toISOString, but it was just never used as commonidentifier.
It was only used in the static lut table.

Anyway as we now need toISOString as identifier it makes sense to add it


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105631/#review16171
-----------------------------------------------------------


On July 20, 2012, 6:57 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105631/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 6:57 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement Date.toJSON
> 
> according to ecmascript edition 5.1r6 - 15.9.5.44 
> 
> 
> Diffs
> -----
> 
>   kjs/CommonIdentifiers.h 8ee40e8 
>   kjs/date_object.h ed45720 
>   kjs/date_object.cpp 8a1fc2c 
> 
> Diff: http://git.reviewboard.kde.org/r/105631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120720/5fe7eb6e/attachment.htm>


More information about the kde-core-devel mailing list