Review Request: kjs: Implement Date.toJSON

Rolf Eike Beer kde at opensource.sf-tec.de
Fri Jul 20 23:22:09 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105631/#review16171
-----------------------------------------------------------



kjs/CommonIdentifiers.h
<http://git.reviewboard.kde.org/r/105631/#comment12766>

    toJSON is already present and you add toISOString? Are you sure this is the right diff?


- Rolf Eike Beer


On July 20, 2012, 6:57 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105631/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 6:57 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement Date.toJSON
> 
> according to ecmascript edition 5.1r6 - 15.9.5.44 
> 
> 
> Diffs
> -----
> 
>   kjs/CommonIdentifiers.h 8ee40e8 
>   kjs/date_object.h ed45720 
>   kjs/date_object.cpp 8a1fc2c 
> 
> Diff: http://git.reviewboard.kde.org/r/105631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120720/487413a2/attachment.htm>


More information about the kde-core-devel mailing list