RFC: Moving KWallet Password dialog into Plasma

[Thomas Lübking]

2012/7/20, Martin Gräßlin <mgraesslin at kde.org>:


> The main problem here is that $service ask for a password through
> $otherservice. This utterly fails because the $service is not linked
> directly
> to a window which the window manager would need to properly stack the
> window.

Yes.

> Now if we think about it in most cases $service is actually a "system"
> service

no - many clients as esp. browsers rely on kwallet - even non kde ones.
they have proper knowledge about a distinct main window.
That however does not cover the "many wallet clients" issue.

> So here my idea: let's move the password dialog into the desktop shell.
Like into the plasma-desktop process which shares memory with random
plasmoids of questionable source?
No. And I mean "no way". The wallet password dialog isn't very secure
anyway, but passing the password through plasma means to open it
anywhere. (next step is dbus to pass it down to kwalletd?)

> it as a so-called "persistent" notification popping out of the panel and be
> shown on top of all other windows till the user either dismisses it or
> enters the password.
It can be a popup anyway - regardless of the parenting process.
Have it grab the keyboard on mouse press but not grab the pointer or
by this closing on external clicks.
It can then position itself to the systray / a SNI / upper right/left
corner - whatever.

> I think this would solve most of our current issues. There would be one
> place where the dialog is shown to ask for the password,
i agree on that aspect, but...

> it is visually clear that
> it's a system service which asks for the password
... the danger is here that users misinterpret it as "system message
annoyance i don't care about" because there's no obvious relation
(blocking their current task) and that also means there's no strong
hint why the irc on the lower left just froze while that dialog in the
upper right shows up.


> and not some random malware
i'm waiting for the first "very important" client to feign a system message :(

> So what do you think?
https://bugs.kde.org/show_bug.cgi?id=92845

not read through it, but gg found it immediately ;-)

Cheers,
Thomas