Review Request: KWallet Password Prompt Dialog In Your Face

[Allen Winter]

> On July 20, 2012, 2:17 p.m., Thomas Lübking wrote:
> > kwalletd/kwalletd.cpp, lines 353-359
> > <http://git.reviewboard.kde.org/r/105628/diff/1/?file=73793#file73793line353>
> >
> >     What's the point of demanding attention when the very next step is to force the window to be active what will clear that state - confuse libtaskbar?

probably don't need the demand attention.  but i don't think it hurts


> On July 20, 2012, 2:17 p.m., Thomas Lübking wrote:
> > kwalletd/kwalletd.cpp, line 357
> > <http://git.reviewboard.kde.org/r/105628/diff/1/?file=73793#file73793line357>
> >
> >     Faking the usertime stamp is only good to cheat the focus stealing prevention, but you're invoking the tool flag ("forceActive") what completely bypasses the FSP anyway

usertime is the only way I could find so that the prompt dialog couldn't be hidden by the main kmail window.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105628/#review16155
-----------------------------------------------------------


On July 20, 2012, 1:41 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105628/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 1:41 p.m.)
> 
> 
> Review request for KDE Runtime, David Faure and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> This is an attempt to make the KWallet password prompt much harder to ignore or miss.
> 
> Now the prompt should always be in front of the parent window. and it should unminimize if needed, and demand attention.
> 
> 
> Diffs
> -----
> 
>   kwalletd/kwalletd.cpp 309c45f 
> 
> Diff: http://git.reviewboard.kde.org/r/105628/diff/
> 
> 
> Testing
> -------
> 
> Just using it in various scenarios.
> For example, if the akonadi maildispatcher needs to open kwallet now the password prompt is always in front of kmail
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120720/3624205c/attachment.htm>