Review Request: KWallet Password Prompt Dialog In Your Face

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105628/#review16155
-----------------------------------------------------------


The point is that one process (akonadi) shall be able to get the dialog on top of a random different (probably fullscreen?) window, yesno?

KWindowSystem::forceActiveWindow(wId);
KWindowSystem::raiseWindow(wId);

alone will do that - but as Christoph and Martin pointed out: it's an incredibly nasty way - you're abusing tools meant for pagers and taskbars here.


kwalletd/kwalletd.cpp
<http://git.reviewboard.kde.org/r/105628/#comment12741>

    "activeDialog()->show()" and that's (unless it's reparented) the same as ...



kwalletd/kwalletd.cpp
<http://git.reviewboard.kde.org/r/105628/#comment12743>

    What's the point of demanding attention when the very next step is to force the window to be active what will clear that state - confuse libtaskbar?



kwalletd/kwalletd.cpp
<http://git.reviewboard.kde.org/r/105628/#comment12744>

    Faking the usertime stamp is only good to cheat the focus stealing prevention, but you're invoking the tool flag ("forceActive") what completely bypasses the FSP anyway



kwalletd/kwalletd.cpp
<http://git.reviewboard.kde.org/r/105628/#comment12742>

    ... unminimizeWindow what's the same as activeDialog->show()


- Thomas Lübking


On July 20, 2012, 1:41 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105628/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 1:41 p.m.)
> 
> 
> Review request for KDE Runtime, David Faure and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> This is an attempt to make the KWallet password prompt much harder to ignore or miss.
> 
> Now the prompt should always be in front of the parent window. and it should unminimize if needed, and demand attention.
> 
> 
> Diffs
> -----
> 
>   kwalletd/kwalletd.cpp 309c45f 
> 
> Diff: http://git.reviewboard.kde.org/r/105628/diff/
> 
> 
> Testing
> -------
> 
> Just using it in various scenarios.
> For example, if the akonadi maildispatcher needs to open kwallet now the password prompt is always in front of kmail
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120720/88011b0b/attachment.htm>