Review Request: [PATCH] Make kio_info produce valid HTML

Wed Jul 18 02:52:02 BST 2012

> On July 17, 2012, 2:35 a.m., Michael Pyne wrote:
> > I think the current best-practice for HTML is a doctype of (and I'm not kidding) <!DOCTYPE html>, which also prevents requiring a manual annotation of text/css later in the style sheets. However these changes (except the question of the missing <div>) are harmless so they can be committed. A long-term project for those who are interested would be to find if there are more suitable info->html converters available instead of old Perl scripts (and likewise for man pages). Maybe pandoc?
> 
> Paul Walger wrote:
>     Not really, <!DOCTYPE html> is the doctype of HTML5 and it is still under development.

Well I'm not sure there will ever be an HTML 5 "official release" as such, but it's true that the doctype I mentioned should be the standard doctype for the new HTML. The reason they recommend that doctype is because it degrades nicely and "does the right thing" even in current browsers, if I'm understanding their logic correctly.

I understand this doesn't help with your goal of getting the output to validate though, so don't take that as a technical objection on my part.

> On July 17, 2012, 2:35 a.m., Michael Pyne wrote:
> > kioslave/info/kde-info2html, line 687
> > <http://git.reviewboard.kde.org/r/105590/diff/1/?file=73032#file73032line687>
> >
> >     Was there a reason this div was removed?
> 
> Paul Walger wrote:
>     Because it was not used. The closing tag was missing and nowhere referenced in the css files.
>     So i assumed that it is useless and just producing invalid html because of the missing tag.

I've verified that the closing tag was indeed missing. However the contents <div> is needed due to the style sheet, otherwise the content goes flush to the window boundary which looks decidedly unpleasant in appearance. I would try adding an additional </div> to the PrintFooter subroutine (just before the footer div is opened).

- Michael

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105590/#review15990
-----------------------------------------------------------

On July 16, 2012, 11:38 a.m., Paul Walger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105590/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 11:38 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Fixes Bug 295170.
> 
> 
> This addresses bug 295170.
>     http://bugs.kde.org/show_bug.cgi?id=295170
> 
> 
> Diffs
> -----
> 
>   kioslave/info/kde-info2html bff85bbde3f3a66467f7f198ee8c4eae25aa1f6d 
> 
> Diff: http://git.reviewboard.kde.org/r/105590/diff/
> 
> 
> Testing
> -------
> 
> Tested via http://validator.w3.org
> 
> 
> Thanks,
> 
> Paul Walger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120718/d7173cc8/attachment.htm>