Review Request: [PATCH] Make kio_info produce valid HTML

Tue Jul 17 13:03:58 BST 2012

> On July 17, 2012, 2:35 a.m., Michael Pyne wrote:
> > I think the current best-practice for HTML is a doctype of (and I'm not kidding) <!DOCTYPE html>, which also prevents requiring a manual annotation of text/css later in the style sheets. However these changes (except the question of the missing <div>) are harmless so they can be committed. A long-term project for those who are interested would be to find if there are more suitable info->html converters available instead of old Perl scripts (and likewise for man pages). Maybe pandoc?

Not really, <!DOCTYPE html> is the doctype of HTML5 and it is still under development.

> On July 17, 2012, 2:35 a.m., Michael Pyne wrote:
> > kioslave/info/kde-info2html, line 687
> > <http://git.reviewboard.kde.org/r/105590/diff/1/?file=73032#file73032line687>
> >
> >     Was there a reason this div was removed?

Because it was not used. The closing tag was missing and nowhere referenced in the css files.
So i assumed that it is useless and just producing invalid html because of the missing tag.

- Paul

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105590/#review15990
-----------------------------------------------------------

On July 16, 2012, 11:38 a.m., Paul Walger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105590/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 11:38 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Fixes Bug 295170.
> 
> 
> This addresses bug 295170.
>     http://bugs.kde.org/show_bug.cgi?id=295170
> 
> 
> Diffs
> -----
> 
>   kioslave/info/kde-info2html bff85bbde3f3a66467f7f198ee8c4eae25aa1f6d 
> 
> Diff: http://git.reviewboard.kde.org/r/105590/diff/
> 
> 
> Testing
> -------
> 
> Tested via http://validator.w3.org
> 
> 
> Thanks,
> 
> Paul Walger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120717/cf4f9366/attachment.htm>