Review Request: Add submenu support to QML shutdown dialog.

Commit Hook null at kde.org
Tue Jul 17 18:40:29 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105568/#review16018
-----------------------------------------------------------


This review has been submitted with commit 0e325a61a57ff85f15bd3f84e57b5800ef32de07 by Lamarque V. Souza to branch KDE/4.9.

- Commit Hook


On July 14, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105568/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 6:53 p.m.)
> 
> 
> Review request for KDE Runtime and Konstantinos Smanis.
> 
> 
> Description
> -------
> 
> Add support to show submenus in the new QML shutdown dialog. I think this patch can be improved, the GUI too. When I have more time I will go back to improve it, until there you can send suggestions.
> 
> The patch assumes rebootOptions now contains strings like:
> 
> entry1
> submenu1 > subentry 1.1
> submenu1 > subentry 1.2
> submenu2 > subentry 2.1
> submenu2 > subsubmenu 1 > subsubentry 2.1.1
> entry2
> 
> The character '>' is the separator for submenus.
> 
> 
> This addresses bug 297209.
>     http://bugs.kde.org/show_bug.cgi?id=297209
> 
> 
> Diffs
> -----
> 
>   ksmserver/themes/default/ContextMenu.qml 6f2f1fd 
>   ksmserver/themes/default/MenuItem.qml 74bb03f 
>   ksmserver/themes/default/main.qml 7e78761 
> 
> Diff: http://git.reviewboard.kde.org/r/105568/diff/
> 
> 
> Testing
> -------
> 
> Submenus are created and it emits rebootRequested2 signal with the correct index.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/105568/s/635/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120717/2961ff99/attachment.htm>


More information about the kde-core-devel mailing list