<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105568/">http://git.reviewboard.kde.org/r/105568/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 0e325a61a57ff85f15bd3f84e57b5800ef32de07 by Lamarque V. Souza to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Konstantinos Smanis.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated July 14, 2012, 6:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support to show submenus in the new QML shutdown dialog. I think this patch can be improved, the GUI too. When I have more time I will go back to improve it, until there you can send suggestions.
The patch assumes rebootOptions now contains strings like:
entry1
submenu1 > subentry 1.1
submenu1 > subentry 1.2
submenu2 > subentry 2.1
submenu2 > subsubmenu 1 > subsubentry 2.1.1
entry2
The character '>' is the separator for submenus.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submenus are created and it emits rebootRequested2 signal with the correct index.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=297209">297209</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/themes/default/ContextMenu.qml <span style="color: grey">(6f2f1fd)</span></li>
<li>ksmserver/themes/default/MenuItem.qml <span style="color: grey">(74bb03f)</span></li>
<li>ksmserver/themes/default/main.qml <span style="color: grey">(7e78761)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105568/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105568/s/635/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/14/submenus_400x100.jpg" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>