Review Request: Add submenu support to QML shutdown dialog.

[Konstantinos Smanis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105568/#review15841
-----------------------------------------------------------


My QML knowledge is too limited to review your code, but I tested your patch and have the following remarks to make:

1) There is some flickering when hovering a menu item. Dunno if it has to do with my theme (tried Oxygen + Caledonia).
2) There is no proper '&' escaping. Ampersands are falsely treated as keyboard accelerators (the old code provisioned for this). A double ampersand is shown as a single.
3) When the menu item's text is small (~4-5 characters), the arrow is shown very close to the text.

The core functionality seems to be fine, I onlyn noticed the above GUI issues.

- Konstantinos Smanis


On July 14, 2012, 5:48 a.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105568/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 5:48 a.m.)
> 
> 
> Review request for KDE Runtime and Konstantinos Smanis.
> 
> 
> Description
> -------
> 
> Add support to show submenus in the new QML shutdown dialog. I think this patch can be improved, the GUI too. When I have more time I will go back to improve it, until there you can send suggestions.
> 
> The patch assumes rebootOptions now contains strings like:
> 
> entry1
> submenu1 > subentry 1.1
> submenu1 > subentry 1.2
> submenu2 > subentry 2.1
> submenu2 > subsubmenu 1 > subsubentry 2.1.1
> entry2
> 
> The character '>' is the separator for submenus.
> 
> 
> This addresses bug 297209.
>     http://bugs.kde.org/show_bug.cgi?id=297209
> 
> 
> Diffs
> -----
> 
>   ksmserver/themes/default/ContextMenu.qml 6f2f1fd 
>   ksmserver/themes/default/MenuItem.qml 74bb03f 
>   ksmserver/themes/default/main.qml 7e78761 
> 
> Diff: http://git.reviewboard.kde.org/r/105568/diff/
> 
> 
> Testing
> -------
> 
> Submenus are created and it emits rebootRequested2 signal with the correct index.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/105568/s/635/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120714/7f74159b/attachment.htm>