Review Request: Add submenu support to QML shutdown dialog.
Lamarque Vieira Souza
lamarque at kde.org
Sat Jul 14 06:48:21 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105568/
-----------------------------------------------------------
(Updated July 14, 2012, 5:48 a.m.)
Review request for KDE Runtime and Konstantinos Smanis.
Changes
-------
remove extra white spaces.
Description
-------
Add support to show submenus in the new QML shutdown dialog. I think this patch can be improved, the GUI too. When I have more time I will go back to improve it, until there you can send suggestions.
The patch assumes rebootOptions now contains strings like:
entry1
submenu1 > subentry 1.1
submenu1 > subentry 1.2
submenu2 > subentry 2.1
submenu2 > subsubmenu 1 > subsubentry 2.1.1
entry2
The character '>' is the separator for submenus.
This addresses bug 297209.
http://bugs.kde.org/show_bug.cgi?id=297209
Diffs (updated)
-----
ksmserver/themes/default/ContextMenu.qml 6f2f1fd
ksmserver/themes/default/MenuItem.qml 74bb03f
ksmserver/themes/default/main.qml 7e78761
Diff: http://git.reviewboard.kde.org/r/105568/diff/
Testing
-------
Submenus are created and it emits rebootRequested2 signal with the correct index.
Screenshots
-----------
http://git.reviewboard.kde.org/r/105568/s/635/
Thanks,
Lamarque Vieira Souza
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120714/18d42216/attachment.htm>
More information about the kde-core-devel
mailing list