Review Request: Cleanup KVBox

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105558/#review15816
-----------------------------------------------------------


Looks ok, but hard to be 100% sure it's correct, and you mentionned that you only tested compilation. Can you at least do a smoke test of the properties dialog using `kpropsdlgtest ~` (from kio/tests) ?

- David Faure


On July 13, 2012, 5:25 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105558/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 5:25 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Cleanup KVBox
> 
> 
> Diffs
> -----
> 
>   kde3support/kdeui/k3listviewsearchline.cpp b884bdb 
>   kde3support/tests/k3listviewtest.cpp cc69c3a 
>   kfile/kfileplaceeditdialog.cpp 156f457 
>   kio/kfile/kfilesharedialog.cpp 71f6a7c 
>   kio/kfile/kpropertiesdialog.cpp ecbdae8 
>   kioslave/http/kcookiejar/kcookiewin.cpp 4e09500 
>   kutils/kcmoduleproxy.cpp 462a9c9 
>   kutils/ksettings/dialog_p.h f0c9563 
>   security/crypto/crypto.cpp b63f278 
> 
> Diff: http://git.reviewboard.kde.org/r/105558/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120713/2a32790f/attachment.htm>