<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105558/">http://git.reviewboard.kde.org/r/105558/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok, but hard to be 100% sure it's correct, and you mentionned that you only tested compilation. Can you at least do a smoke test of the properties dialog using `kpropsdlgtest ~` (from kio/tests) ?</pre>
<br />
<p>- David</p>
<br />
<p>On July 13th, 2012, 5:25 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleanup KVBox</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde3support/kdeui/k3listviewsearchline.cpp <span style="color: grey">(b884bdb)</span></li>
<li>kde3support/tests/k3listviewtest.cpp <span style="color: grey">(cc69c3a)</span></li>
<li>kfile/kfileplaceeditdialog.cpp <span style="color: grey">(156f457)</span></li>
<li>kio/kfile/kfilesharedialog.cpp <span style="color: grey">(71f6a7c)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(ecbdae8)</span></li>
<li>kioslave/http/kcookiejar/kcookiewin.cpp <span style="color: grey">(4e09500)</span></li>
<li>kutils/kcmoduleproxy.cpp <span style="color: grey">(462a9c9)</span></li>
<li>kutils/ksettings/dialog_p.h <span style="color: grey">(f0c9563)</span></li>
<li>security/crypto/crypto.cpp <span style="color: grey">(b63f278)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105558/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>