Review Request: KHBox cleanup in frameworks

[David Faure]

> On July 12, 2012, 10:20 p.m., Christoph Feck wrote:
> > kde3support/kdeui/k3listviewsearchline.cpp, line 537
> > <http://git.reviewboard.kde.org/r/105531/diff/1/?file=72349#file72349line537>
> >
> >     Do not set fixed spacing, let the style figure it out.
> 
> Albert Astals Cid wrote:
>     Sorry but no, i'm not doing that, i'm removing KHBox, if you want me to do other random stuff, i'm out

The setSpacing(5) was in the orig code indeed, so it shouldn't be changed by this commit. I got fooled too initially, because the setSpacing(5) is a bit further down.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105531/#review15753
-----------------------------------------------------------


On July 12, 2012, 10:18 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105531/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 10:18 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Kill the uses of KHBox
> 
> 
> Diffs
> -----
> 
>   kde3support/kdeui/k3listviewsearchline.h 7073c02 
>   kde3support/kdeui/k3listviewsearchline.cpp 55b7d27 
>   kde3support/kdeui/k3passworddialog.cpp 9ef8ce5 
>   kdeui/dialogs/kpassworddialog.cpp 6ce9eb2 
>   kdeui/tests/kcomboboxtest.cpp 883a0f6 
>   kdeui/tests/ktreewidgetsearchlinetest.cpp 955bc15 
>   kdeui/widgets/kmenu.cpp 95a37c6 
>   kioslave/http/kcookiejar/kcookiewin.cpp 56f6926 
>   kutils/kcmultidialog.cpp 7ff62c9 
> 
> Diff: http://git.reviewboard.kde.org/r/105531/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120712/3982227c/attachment.htm>