Review Request: KHBox cleanup in frameworks

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105531/#review15756
-----------------------------------------------------------



kde3support/kdeui/k3listviewsearchline.h
<http://git.reviewboard.kde.org/r/105531/#comment12244>

    There was no need to port kde3support, it depends on kde4support. But OK, now that you've done it ;)



kde3support/kdeui/k3listviewsearchline.cpp
<http://git.reviewboard.kde.org/r/105531/#comment12245>

    Trailing whitespace, on several lines.



kde3support/kdeui/k3passworddialog.cpp
<http://git.reviewboard.kde.org/r/105531/#comment12243>

    Redundant with line 404.



kioslave/http/kcookiejar/kcookiewin.cpp
<http://git.reviewboard.kde.org/r/105531/#comment12242>

    This line does nothing, you already gave the associated widget on line 90, when creating the layout.


- David Faure


On July 12, 2012, 10:18 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105531/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 10:18 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Kill the uses of KHBox
> 
> 
> Diffs
> -----
> 
>   kde3support/kdeui/k3listviewsearchline.h 7073c02 
>   kde3support/kdeui/k3listviewsearchline.cpp 55b7d27 
>   kde3support/kdeui/k3passworddialog.cpp 9ef8ce5 
>   kdeui/dialogs/kpassworddialog.cpp 6ce9eb2 
>   kdeui/tests/kcomboboxtest.cpp 883a0f6 
>   kdeui/tests/ktreewidgetsearchlinetest.cpp 955bc15 
>   kdeui/widgets/kmenu.cpp 95a37c6 
>   kioslave/http/kcookiejar/kcookiewin.cpp 56f6926 
>   kutils/kcmultidialog.cpp 7ff62c9 
> 
> Diff: http://git.reviewboard.kde.org/r/105531/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120712/0c459998/attachment.htm>