Review Request: proper fix for my inexcusable commit without review

Jaime Torres Amate jtamate at gmail.com
Wed Jul 11 15:53:33 BST 2012


Should i commit it to branch KDE/4.8 & 4.9? (Do i have to send any email to the release team?)

David Faure <faure at kde.org> escribió:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>http://git.reviewboard.kde.org/r/105364/#review15666
>-----------------------------------------------------------
>
>Ship it!
>
>
>Ship It!
>
>- David Faure
>
>
>On June 29, 2012, 4:22 p.m., Jaime Torres Amate wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/105364/
>> -----------------------------------------------------------
>> 
>> (Updated June 29, 2012, 4:22 p.m.)
>> 
>> 
>> Review request for kdelibs.
>> 
>> 
>> Description
>> -------
>> 
>> the action created locally in void KAction::setAuthAction(const
>QString &actionName) is deleted.
>> The others must be handled by the callers of void
>KAction::setAuthAction(KAuth::Action *action).
>> 
>> 
>> Diffs
>> -----
>> 
>>   kdeui/actions/kaction.cpp 0f6343c 
>> 
>> Diff: http://git.reviewboard.kde.org/r/105364/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> working with it this afternoon.
>> 
>> 
>> Thanks,
>> 
>> Jaime Torres Amate
>> 
>>

-- 
Enviado desde mi teléfono Android con K-9 Mail. Disculpa mi brevedad




More information about the kde-core-devel mailing list