Review Request: proper fix for my inexcusable commit without review
David Faure
faure at kde.org
Wed Jul 11 13:25:08 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105364/#review15666
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On June 29, 2012, 4:22 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105364/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 4:22 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> the action created locally in void KAction::setAuthAction(const QString &actionName) is deleted.
> The others must be handled by the callers of void KAction::setAuthAction(KAuth::Action *action).
>
>
> Diffs
> -----
>
> kdeui/actions/kaction.cpp 0f6343c
>
> Diff: http://git.reviewboard.kde.org/r/105364/diff/
>
>
> Testing
> -------
>
> working with it this afternoon.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120711/942d673e/attachment.htm>
More information about the kde-core-devel
mailing list