Review Request: kjs: Implement JSON.parse

[Bernd Buschinski]

> On July 6, 2012, 3:12 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 309
> > <http://git.reviewboard.kde.org/r/105056/diff/7/?file=71399#file71399line309>
> >
> >     What about two commas in a row?

propAdded handles this (tested),

we will hit the TokComma case 2 times in a row

case TokComma: // Skip Comma and parse next Array Element
    // if we found a comma without a leading property, this is invalid syntax
    if (!propAdded)
        return 0;
    propAdded = false;


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15462
-----------------------------------------------------------


On July 5, 2012, 12:50 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 12:50 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120706/097799be/attachment.htm>