Review Request: kjs: Implement JSON.parse

Maks Orlovich maksim at kde.org
Fri Jul 6 16:12:47 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15462
-----------------------------------------------------------



kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment12091>

    What about two commas in a row?



kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment12093>

    what if this puts you past the end of the string?
    


- Maks Orlovich


On July 5, 2012, 12:50 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 12:50 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120706/4f4beb82/attachment.htm>


More information about the kde-core-devel mailing list