Review Request: kjs: Mark Date Infinity as invalid

Bernd Buschinski b.buschinski at googlemail.com
Fri Jul 6 19:30:08 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105387/
-----------------------------------------------------------

(Updated July 6, 2012, 6:30 p.m.)


Review request for kdelibs.


Changes
-------

kjs: Mark Date Infinity as invalid & cleanup


Description
-------

kjs: Mark Date Infinity as invalid

we currently accept Infinity as a valid date, but its not, we even calc with it,
which may or may not lead to a result, but always to the wrong result.

The correct way it to just report it as invalid, as we do by remembering it as NaN.


Diffs (updated)
-----

  kjs/date_object.cpp 8a1fc2c 

Diff: http://git.reviewboard.kde.org/r/105387/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120706/554cf6ac/attachment.htm>


More information about the kde-core-devel mailing list