Review Request: kjs: Mark Date Infinity as invalid

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105387/#review15458
-----------------------------------------------------------



kjs/date_object.cpp
<http://git.reviewboard.kde.org/r/105387/#comment12087>

    Same fix here? (And perhaps in other spots?)
    
    Really, this probably needs some cleanup to not dupe this chunk of code; the spec
    defines one in terms of the other, after all.


- Maks Orlovich


On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105387/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 6:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Mark Date Infinity as invalid
> 
> we currently accept Infinity as a valid date, but its not, we even calc with it,
> which may or may not lead to a result, but always to the wrong result.
> 
> The correct way it to just report it as invalid, as we do by remembering it as NaN.
> 
> 
> Diffs
> -----
> 
>   kjs/date_object.cpp 8a1fc2c 
> 
> Diff: http://git.reviewboard.kde.org/r/105387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120706/ae78a6ff/attachment.htm>