Review Request: Factor out and reuse the code that guesses mime-type from filename

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103617/#review9492
-----------------------------------------------------------



kparts/browseropenorsavequestion.cpp
<http://git.reviewboard.kde.org/r/103617/#comment7778>

    So, this is passing the default mimetype as first argument, knowing very well that it won't be used...
    
    This kind of factorization isn't really factorization :/
    
    If we want to call findByUrl here, why not just call findByUrl...


- David Faure


On Jan. 3, 2012, 5:51 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103617/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2012, 5:51 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> * Factored out the code that is used to determine the actual mime-type from either another mime-type or a filename.
> * Avoid storing the KMimeType::Ptr returned by KMimeType::mimeType as stated in its documentation.
> 
> 
> Diffs
> -----
> 
>   kparts/browseropenorsavequestion.cpp 092198f 
> 
> Diff: http://git.reviewboard.kde.org/r/103617/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120103/ed4732c2/attachment.htm>