Review Request: Factor out and reuse the code that guesses mime-type from filename

Dawit Alemayehu adawit at kde.org
Tue Jan 3 05:51:13 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103617/
-----------------------------------------------------------

(Updated Jan. 3, 2012, 5:51 a.m.)


Review request for kdelibs.


Changes
-------

Updated patch based on David's feedback.


Description
-------

* Factored out the code that is used to determine the actual mime-type from either another mime-type or a filename.
* Avoid storing the KMimeType::Ptr returned by KMimeType::mimeType as stated in its documentation.


Diffs (updated)
-----

  kparts/browseropenorsavequestion.cpp 092198f 

Diff: http://git.reviewboard.kde.org/r/103617/diff/diff


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120103/3ca166f0/attachment.htm>


More information about the kde-core-devel mailing list