Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression
thiago at kde.org
Mon Jan 2 22:57:32 GMT 2012
On Monday, 2 de January de 2012 22.18.45, Thomas Baumgart wrote:
> on Monday 02 January 2012 22:08:48 Thiago Macieira wrote:
> > On Monday, 2 de January de 2012 18.53.12, Dawit Alemayehu wrote:
> > > Diff: http://git.reviewboard.kde.org/r/103610/diff/diff
> > 404 - Page does not exist
> > Reviewboard broken?
> Try https://git.reviewboard.kde.org/r/103610/diff/
Now I can't find my reviewboard password. It's on the other laptop, which is
11000 km away.
Anyway, I looked at the change and gave up reviewing it. Dawit, can you make a
change that doesn't move code around unnecessarily? If you're going to move
code around, only do that. Then make the other change.
The change has two other problems:
1) it requires new API in kdecore
2) it uses new API in Qt 4.8 that wasn't API reviewed. I want to change it in
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 190 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel