Review Request: KJS: Correctly get begin, deleteCount for Splice
Bernd Buschinski
b.buschinski at googlemail.com
Tue Feb 28 15:12:57 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104104/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
Corretly get the begin and deleteCount for Splice. The current implementation only allows max int values.
But ecmascript 15.4.4.12 allows max UInt32 (via ToInteger(which is a double) and limits it to the array length(uint32))
This addresses bug 276629.
http://bugs.kde.org/show_bug.cgi?id=276629
Diffs
-----
kjs/array_object.cpp 0da29b0
Diff: http://git.reviewboard.kde.org/r/104104/diff/
Testing
-------
Confirmed via ecmascript 15.4.4.12
Thanks,
Bernd Buschinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120228/4d46368c/attachment.htm>
More information about the kde-core-devel
mailing list