Review Request: kdepasswd KCM: add option to remove the user image

[Ralf Jung]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104054/
-----------------------------------------------------------

(Updated Feb. 24, 2012, 1:25 p.m.)


Review request for KDE Base Apps.


Changes
-------

I fixed the "Remove Image" and added the ellipsis to the original string.
I am not a usability export, personally I think "Custom Image..." is understandable, as the ellipsis indicates that clicking it will open the file selection dialogue. "Load Custom Image..." would make the buttons dominate the width of the dialogue, which IMHO looks ugly. I'd also like "Load Image...", though.


Description
-------

Currently it is possible to set a user image using the kdepasswd KCM, but it is not possible to remove that image again. This patch adds an appropriate option to the dialogue that pops up when clicking the current image.

It also adds "i18n" which obviously was forgotten for another button.


Diffs (updated)
-----

  kdepasswd/kcm/chfacedlg.h c389e49 
  kdepasswd/kcm/chfacedlg.cpp a80c5af 
  kdepasswd/kcm/main.cpp b664f98 

Diff: http://git.reviewboard.kde.org/r/104054/diff/


Testing
-------

Compiled, and verified that images are properly set up and removed again.


Thanks,

Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120224/bd3c82ef/attachment.htm>