Review Request: kdepasswd KCM: add option to remove the user image

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104054/#review10864
-----------------------------------------------------------



kdepasswd/kcm/chfacedlg.cpp
<http://git.reviewboard.kde.org/r/104054/#comment8797>

    The first string is confusing, partly because it lacks the ellipsis, partly because it doesn't associate the file dialog. "Open Image ..."? "Load File ..."? "Import Custom Image ..."? Not sure.
    
    The second string should be "Remove Image" to be HIG compliant.


- Christoph Feck


On Feb. 23, 2012, 8:53 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104054/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 8:53 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Currently it is possible to set a user image using the kdepasswd KCM, but it is not possible to remove that image again. This patch adds an appropriate option to the dialogue that pops up when clicking the current image.
> 
> It also adds "i18n" which obviously was forgotten for another button.
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfacedlg.h c389e49 
>   kdepasswd/kcm/chfacedlg.cpp a80c5af 
>   kdepasswd/kcm/main.cpp b664f98 
> 
> Diff: http://git.reviewboard.kde.org/r/104054/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and verified that images are properly set up and removed again.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120224/77a3c7ab/attachment.htm>