Review Request: make folderview compile with Qt 4.7

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104030/#review10768
-----------------------------------------------------------


Isn't the Q_ASSERT in the wrong block?

And I'd rather use a boolean variable indicating that the item was found, then doing if (!success) {...} after the for loop. Avoid "return" statements in deeply nested code (hard to debug).

- Kevin Funk


On Feb. 20, 2012, 5:18 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104030/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 5:18 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Currently, kde-baseapps does not compile against Qt 4.7, in contrast to what cmake checks. This patch fixes the only place where Qt 4.8 API was used.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/actionoverlay.cpp 791cfdf 
> 
> Diff: http://git.reviewboard.kde.org/r/104030/diff/
> 
> 
> Testing
> -------
> 
> compile-tested
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120220/a8b63cb4/attachment.htm>